TDC just exits rather than raising an exception
davidegraff opened this issue · 1 comments
Describe the bug
This isn't so much of a bug as it is a suboptimal developer. In certain instances when attempting to load a dataset with an improper task name, TDC causes the whole program to exit
To Reproduce
from tdc.single_pred import ADME
ADME("caco2_wang", label_name="bad task name")
# Found local copy...
# Loading...
# ['Drug_ID' 'Drug' 'Y']
# Please report this error to contact@tdcommons.ai, thanks!Expected behavior
That TDC would raise a more descriptive Exception rather than just exiting, allowing the end user to (1) except it, if necessary, and (2) diagnose it via a full stack trace.
More Details
the culprit in my instance is specifically here. The blanket except in L334 is likely catching the appropriate exception raised in fuzzy_search() and instead just exiting the program. IMO you should be propagating the error or at least convert it to a different error rather than just exiting
Great point, will update the try-exception scheme