Material conversion for landscape scene could be improved
mmp opened this issue · 3 comments
Some of the plant colors aren't great. This green is particularly off:
This might be related: in the landscape scene there are 268 MakeNamedMaterial directives but 0 NamedMaterial directives, so none of the named materials are ever actually used.
P.S. thanks for making such wonderful scenes available!
In the PBRTv3 version of the scene, there are the same number of MakeNamedMaterial directives and they all seem to be used as parameters to mix materials. There don't seem to be any mix materials in the PBRTv4 scene. Maybe pbrt --upgrade missed them out?
Good clue, though that turns out to actually be a red herring. (Basically, pbrt-v3's BSDF models were very much of the "add a bunch of lobes together until it looks good" form, while v4 tries to be a bit more principled; those are leftovers from the automated conversion of the scene.)
That said, this inspired me to spend more time on the scene, improving both the lighting and material conversion. It's a lot better now and matches the v3 version of the scene pretty well.
