MinimumScaleMode: FIT
p-lr opened this issue · 17 comments
Exactly as we had in v2, the MinimumScaleMode.FIT would be very much appreciated.
To explain it with real example, ScalingScrollView.MinimumScaleMode.CONTAIN gives me:
And ZoomPanLayout.MinimumScaleMode.FIT gave me:
I have other issues coming, but they're very easy to fix and I'll PR for them.
Ok nice. I think there are just a few things to address to get the same level of maturity of the v2. It's close!
OK I'll be working on bugs tomorrow night, starting here, so feel free to post any other issues you want prioritized.
Great. I think I'll have some time this weekend. And also I need to continue the book review.
👍
If you call tileViewInstance.setMinimumScaleMode(ScalingScrollView.MinimumScaleMode.CONTAIN) does it do what you want? What about tileViewInstance.setMinimumScaleMode(ScalingScrollView.MinimumScaleMode.COVER) ?
I gave an example of what CONTAIN gives (in the OP), so it isn't what I'm looking for. As for COVER, it can only zoom out to the point the screen is fully covered by the map but a significant part of it isn't visible. In fact the screenshot I gave for FIT with the previous version is exactly what I want.
hm ok i thought i copied those over exactly but most not have. i'll get back to it!
Well CONTAIN only lacks the centering of the map.
ah ok gtk!
so just to be clear.
CONTAIN is basically FIT but doesn't center, and it should center. if i get CONTAIN to center, CONTAIN can be considered "passing".
COVER works as it is and does not actually need any tweaks, it's just not what you're using, but isn't actually broken - or do you consider your description, here, a bug:
As for COVER, it can only zoom out to the point the screen is fully covered by the map but a significant part of it isn't visible.
Sorry for being thick today, trying to do this during blocked times at work, and just diving back into some features I haven't touched for quite some time.
Gotta run, back in a couple hours
ooph. i'm working on this but it's tricky. iirc someone else did the original and i guess i need to familiarize myself with the concepts, generally.
Ok I'll get some time tonight to look at this, thanks.