navinlabcode/copykit

name of findNormalCells is slightly misleading

Closed this issue · 1 comments

Technically it is marking cells as euploid or aneuploid, not as "normal." Normal implies "not tumor", but with this function euploid tumor cells would be marked as "normal" and functionally normal cells with a chromosome loss would not be marked as "normal". I guess my point is that calling them "normal" is imposing a status on the cells which you aren't always sure about. I think findAneuploidCells would be more accurate and is actually what you're trying to use the function for most of the time.

Agreed, renamed to findAneuploidCells