cnn-encoder part of Actor in sac.py would never be updated?

[emigmo]

Hi, here

dmcontrol-generalization-benchmark/src/algorithms/sac.py

Line 104 in ee658ce

_, pi, log_pi, log_std = self.actor(obs, detach=True)

As the detach=True, all the cnn-encoder parts of the actor would not be updated? is it right? or you do not want to update the cnn encoder of the actor?

or am I missing something?

[nicklashansen]

Hi, the cnn layers of the encoder (shared_cnn in the code) are shared between actor and critic, and only the critic updates those layers. We largely follow the implementation of pytorch_sac.