Clean up after merging prototype/task_v2-2

[aaronchongth]

Moved all outstanding items from #582 to this new ticket, after merging into main,

• Fix lint errors in react-component tests
  • components used by reporting is causing some of the lint errors, fixing these will require updating reporting to work with taskv2 as well. Alternative is to remove reporting from this repo altogether and move it to it's own repo.
• Restore various tests that were commented out
  • Tests regarding components in robot pages are done.
  • Components in tasks page are still missing tests.
  • e2e tests need to be updated as well.
• Fix bug where notification of failed submissions from other interfaces shows up on the dashboard.
• Check that no intended edits were lost at sea 🌊
• Clean up all the code that is no longer required
• (Edited) Dashboard Delivery Form might be good to have validation to prevent invalid inputs. SKU: string, Quantity: int, > 0
• 1 decimal precision for battery %

Portions that might require attention:

• react-components

  • https://github.com/open-rmf/rmf-web/tree/main/packages/react-components/lib/reports/task-summary/task-summary-report-table.tsx#L15
    • CI seems to say task_profile: any was unexpected
  • https://github.com/open-rmf/rmf-web/tree/main/packages/react-components/lib/reports/task-summary/utils.tsx#L5
    • CI warnings as well as commented out imports
  • https://github.com/open-rmf/rmf-web/tree/main/packages/react-components/lib/tasks/create-task.spec.tsx
  • https://github.com/open-rmf/rmf-web/tree/main/packages/react-components/lib/tasks/task-info.tsx

• dashboard

  • https://github.com/open-rmf/rmf-web/tree/main/packages/dashboard/src/components/dashboard/tests/items.ts
  • https://github.com/open-rmf/rmf-web/tree/main/packages/dashboard/src/components/permissions.ts
    • Looks like permission checking was removed for now
  • https://github.com/open-rmf/rmf-web/tree/main/packages/dashboard/src/components/robots/robot-page.tsx
    • FIXME: RobotTable does not know about which fleet a robot belongs to, so there is no way to distinguish between robots with the same name in different fleets, events fired by RobotTable, will be broken in that case.
    • Ideally we would like to add a test for this as well once it has been fixed
  • https://github.com/open-rmf/rmf-web/tree/main/packages/dashboard/src/components/tasks/task-panel.tsx
  • https://github.com/open-rmf/rmf-web/tree/main/packages/dashboard/src/components/tasks/task-panel.tsx#L226
  • https://github.com/open-rmf/rmf-web/tree/main/packages/dashboard/src/components/tasks/tests/make-tasks.ts
  • https://github.com/open-rmf/rmf-web/tree/main/packages/dashboard/src/components/tasks/tests/task-panel.test.tsx
  • https://github.com/open-rmf/rmf-web/tree/main/packages/dashboard/src/stories/baseComponents/utils.tsx
  • https://github.com/open-rmf/rmf-web/tree/main/packages/dashboard/src/stories/task-panel.stories.tsx

I might have missed out some items while going through #582. Please feel free to add to the list.

[mayman99]

Great Issue 👍
Also I'll be working on this branch for the reporting side, at the moment reporting doesn't work on main

[mayman99]

I've opened this PR to fix this issue, feel free to push directly, just mention what you would work on when you start to avoid conflicts.
atm I'm cleaning the tasks, removing extra code and un-commenting tests one by one.