openhab/openhab-core

Replace deprecated `hamcrest-library` with `hamcrest` in test BOM

david-pace opened this issue · 4 comments

david-pace commented

While developing unit tests, I noticed that the test dependencies contain hamcrest-library and hamcrest-core. These two libraries are obsolete in the mean time because everything was combined into hamcrest.

Both libraries contain text files and Javadocs saying:

All the classes in hamcrest-core.jar and hamcrest-library.jar has moved
into hamcrest.jar. Please update your dependencies.

I found that the dependency is defined in org.openhab.core.bom.test/pom.xml:

<dependency>
    <groupId>org.hamcrest</groupId>
    <artifactId>hamcrest-library</artifactId>
    <version>2.2</version>
</dependency>

It yields this dependency hierarchy:

hamcrest-library
+- hamcrest-core
     +- hamcrest

Since the first two libraries are deprecated/obsolete, we should directly depend on hamcrest instead of hamcrest-library. I will provide a PR soon.

david-pace commented

I opened PR #4113, but I don't have the rights to link it here or to assign reviewers. @jlaur could you please perform the necessary actions or tell me who I should contact?

jlaur commented

I opened PR #4113, but I don't have the rights to link it here or to assign reviewers. @jlaur could you please perform the necessary actions or tell me who I should contact?

You should be able to link it by providing a text like "Resolves #4112" in the PR description. I see it is already assigned to the maintainers for review.

  • 👍1
david-pace commented

Thanks @jlaur, that worked 👍

btw, I chose the enhancement template because it was the closest match, but I guess this only concerns developers and should probably not be mentioned in the release notes. If you have a more appropriate label for this kind of maintenance changes, please feel free to remove the enhancement label and add a better one.

jlaur commented

btw, I chose the enhancement template because it was the closest match, but I guess this only concerns developers and should probably not be mentioned in the release notes. If you have a more appropriate label for this kind of maintenance changes, please feel free to remove the enhancement label and add a better one.

I'm not a maintainer for this repository, but the maintainers will usually set an appropriate label during the review/merge process. 🙂

  • 👍1