missing inline in limbo/opt/optimizer.hpp

Question

InriaBrice opened this issue 6 years ago · 5 comments

hey,

I got multiple definition of function, it is missing inline in limbo/opt/optimizer.hpp

best,

Answer 1 · 2018-07-04T16:52:45.000Z

I got multiple definition of function, it is missing inline in limbo/opt/optimizer.hpp

Which function?

Answer 2 · 2018-07-04T16:55:35.000Z

I will do it. I talked to Brice.

On Wed, Jul 4, 2018, 18:53 Konstantinos Chatzilygeroudis < ***@***.***> wrote: I got multiple definition of function, it is missing inline in limbo/opt/optimizer.hpp Which function? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#276 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFu8v6YkdfCom8tNRM7VisJNkn_IWn9Tks5uDPLdgaJpZM4VC1_r> .

Answer 3 · 2018-07-04T16:57:15.000Z

I will do it. I talked to Brice.

I don't get what's the issue.. What is the problem? Why do we need inline?

Answer 4 · 2018-07-04T17:00:53.000Z

We have many functions (not methods) that are not declared inline. This creates issues when they are used in different .o (multiple definitions)

On Wed, Jul 4, 2018, 18:57 Konstantinos Chatzilygeroudis < ***@***.***> wrote: I will do it. I talked to Brice. I don't get what's the issue.. What is the problem? Why do we need inline? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#276 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFu8v1EHZWcjzoVaSMEj98QH39-yGzfRks5uDPPsgaJpZM4VC1_r> .

Answer 5 · 2018-07-05T13:48:02.000Z

Fixed in #277 ...