Feedback on Preamble and Chapter 1 - RISC-V N-Trace (Nexus-based Trace) Specification
Closed this issue · 1 comments
ved-rivos commented
- Specification state should be Stable till AR completes and specification is Freeze approved.
- Copyright and license - please update to follow the template.
- "specification for complete end-to-end trace system" may be misleading of the specification as this spec provides the trace contents.
- Introduction can be made better and reworded to be a better introduction to the core of the specification.
- The statement "will be followed by Nexus compliant data.." - not sure its needed here but it should be non-normative - it "may" be followed by data trace, etc"
- The para on trace control layer and connectors should move into the corresponding specifications.
- Reword the informative note e.g. "besides PDF files provided below". Usually donations are to a TG and specifications provided by TG are RVI specifications.
- Section 1.2 - abruptly starts with a diagram - without enough introduction on what the specification is about.
- Fig 1 - It is possible that the Encoder and Control Layer will reside within the hart. It would probably be hard to include both options in a diagram, but a non-normative statement clarifying that the diagram is one possible implementation option would be helpful.
- Table 1 - Field - "may span across multiple bytes" -> "may span multiple bytes". Punctuation need to be fixed in various places in the table.
- Table 1 - Variable-length Field - "When messages are transferred" -> "When messages are transmitted" to consistently match terminology used in the last sentence of this description.
mipsrobert commented
I am closing all N-Trace PDF related issues with same comments as all issues were handled via comments/discussions in SINGLE Google Docs. Relevant links are as follows:
Notes to N-Trace PDF: https://docs.google.com/document/d/1h__c0Kc7TQAWMh5bw9cNC9bl_IGqyY_ylPV14uc2xj0