Feedback on chapter 4 - RISC-V N-Trace (Nexus-based Trace) Specification
ved-rivos opened this issue · 2 comments
ved-rivos commented
- Since the primary purpose of the table is to show which controls are required and which are optional, the first paragraph should be reworded - specifically "describes fields and bits" as this table is not intended to describe the fields and bits and how they influence the encoder.
- "May be hard-coded" - dont need to state this as these are WARL fields.
- trTeInstSyncMax - "Controls generation of Sychronization Messages (with SYNC field=2)". The parenthesis is not needed as this only affects periodic synchronization?
- trTeProtocolMajor - The second sentence should be removed.
- trTeProtocolMinor - The sentence "Different values are..." should be removed. The last sentence should be reworded as the protocol major/minor are not part of messages or the wire protocol. These are trace encoder inputs. The verbiage implies that tools will have these trace controls as input
- rows marked as "Future" should be marked as Not applicable and set to 0 since this is a specification for this version of the specification.
- Why is trTsEnable in a informative note and not in the table? What is treatment for other trTs* fields?
- Instead of repeating "See RISC-V Trace Control Interface Specification" - this can be in the leading paragraph. The cell can be left empty if there is no specific comment to be made. Alternatively only the rows that have N-trace specific clarification can be listed and rest referred to the control interface specification without repeating them here. This would also avoid ambiguity about fields left out of this table.
- A one bit field is also a field. Does the bit/field need to be differentiated?
mipsrobert commented
I am closing all N-Trace PDF related issues with same comments as all issues were handled via comments/discussions in SINGLE Google Docs. Relevant links are as follows:
Notes to N-Trace PDF: https://docs.google.com/document/d/1h__c0Kc7TQAWMh5bw9cNC9bl_IGqyY_ylPV14uc2xj0
mipsrobert commented
I am closing all N-Trace PDF related issues with same comments as all issues were handled via comments/discussions in SINGLE Google Docs. Relevant links are as follows:
Notes to N-Trace PDF: https://docs.google.com/document/d/1h__c0Kc7TQAWMh5bw9cNC9bl_IGqyY_ylPV14uc2xj0