Could you build a specific function for plotting of outliers?

Hi,
I think it would be clearer and useful to thave a plot function outside of the TestOutliers function.
From my experience, it is better to separate computation and graphics.

FlowSOM/R/3_buildMST.R

Line 379 in dd61602

if (!is.null(plotFile)) {

Best.

Hi Samuel, Thanks for the suggestion! I fully agree, but I am currently also in the process of further extending and optimizing the code to detect outliers. I will take this suggestion along when I update that whole step. All the best, Sofie

…

On Thu, 26 Jan 2023 at 10:27, Samuel Granjeaud ***@***.***> wrote: Hi, I think it would be clearer and useful to thave a plot function outside of the TestOutliers function. From my experience, it is better to separate computation and graphics. https://github.com/saeyslab/FlowSOM/blob/dd6160291007767fbb23f3e5421a67e0d3d7b855/R/3_buildMST.R#L379 Best. — Reply to this email directly, view it on GitHub <#17>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAOS72YI3O56NRIO5LUCBTTWUI7QRANCNFSM6AAAAAAUHIZ5V4> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

Hi Sofie,
Thanks for your feedback. No urge.
If you are modifying the code, I would propose you to make it more compact and more formatted to the left side of the screen.
Best.