Allow some imports of RLF to fail

Question

Allow some imports of RLF to fail

Closed this issue 4 years ago · 31 comments

The RealLazyField implementation is tied closely to real_mpfr.

We modify some imports for the purpose of modularization, in particular sagemath-polyhedra (#32432)

In particular for ... is RLF tests:

$ git grep 'is RLF'
src/sage/rings/complex_double.pyx:        if S is ZZ or S is QQ or S is RDF or S is RLF:
src/sage/rings/number_field/number_field_base.pyx:        if codomain is AA or codomain is RLF:
src/sage/rings/real_double.pyx:        if S is ZZ or S is QQ or S is RLF:
src/sage/schemes/plane_conics/con_number_field.py:                if not (isinstance(p, Map) and p.category_for().is_subcategory(Rings())) or p.codomain() is AA or p.codomain() is RLF:

Depends on #32742
Depends on #32750
Depends on #32733

CC: @kliem @tscrim @sagetrac-tmonteil

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: b49bbdf

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/32777

Answer 1 · 2021-10-26T21:37:44.000Z

Dependencies: #32742

Answer 2 · 2021-10-26T22:19:29.000Z

Branch: u/mkoeppe/allow_some_imports_of_rlf_to_fail

Answer 3 · 2021-10-26T22:20:28.000Z

Author: Matthias Koeppe

Answer 4 · 2021-10-26T22:20:28.000Z

Last 10 new commits:

`b3c1667`	`Merge #32758`
`ce8687b`	`Merge #32612`
`15884f3`	`src/sage/matrix/matrix_space.py: Import element classes on demand, fall back to generic on ImportError`
`ac58286`	`Matrix.gram_schmidt: Use sage.rings.abc`
`6d4ee6e`	`Matrix.gram_schmidt: Use sage.rings.abc (fixup)`
`a1362ee`	`Merge #32635`
`c53d15d`	`Merge #32742`
`26df548`	`src/sage/rings/number_field/number_field_base.pyx: Handle failing import of AA, RLF`
`054a8a6`	`src/sage/rings/real_double.pyx: Handle failing import of RLF, RR`
`5ff97b1`	`src/sage/schemes/plane_conics/con_number_field.py: Move imports of RLF, AA into methods`

Answer 5 · 2021-10-26T22:20:28.000Z

Commit: 5ff97b1

Answer 6 · 2021-10-28T05:12:36.000Z

comment:5

This failure is not from this ticket:

sage -t --long --random-seed=321172385432269463934777057410284981568 src/sage/rings/integer.pyx  # 1 doctest failed

This failure is likely from random seed fuzzing, not this ticket:

sage -t --long --random-seed=321172385432269463934777057410284981568 src/sage/rings/polynomial/multi_polynomial_ring_base.pyx  # 1 doctest failed

reported in #32544.

Answer 7 · 2021-10-29T00:24:02.000Z

Changed commit from 5ff97b1 to bda5ef8

Answer 8 · 2021-10-29T00:24:02.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`bda5ef8`	`Merge tag '9.5.beta5' into t/32777/allow_some_imports_of_rlf_to_fail`

Answer 9 · 2021-11-04T05:50:19.000Z

Changed commit from bda5ef8 to 59b67d3

Answer 10 · 2021-11-04T05:50:19.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`35cdcff`	`src/sage/groups/misc_gps/argument_groups.py: Remove unused imports`
`59b67d3`	`src/sage/schemes/projective/projective_morphism.py: Remove unused imports`

Answer 11 · 2021-11-04T21:17:38.000Z

comment:9

One green bot; one bot that's not feeling well

Answer 12 · 2021-11-04T21:22:06.000Z

comment:10

Replying to @mkoeppe:

One green bot; one bot that's not feeling well

I stopped all my patchbots.

Answer 13 · 2021-11-06T01:40:43.000Z

Reviewer: Travis Scrimshaw

Answer 14 · 2021-11-06T17:44:03.000Z

comment:12

Thank you!

Answer 15 · 2021-11-07T09:42:25.000Z

comment:13

Merge conflict

Answer 16 · 2021-11-07T16:58:53.000Z

Changed dependencies from #32742 to #32742, #32750

Answer 17 · 2021-11-07T16:59:07.000Z

Changed commit from 59b67d3 to c219c17

Answer 18 · 2021-11-07T16:59:07.000Z

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

`96a778b`	`src/sage/schemes/elliptic_curves/constructor.py: Use sage.rings.abc.pAdicField`
`b672836`	`src/sage/schemes/hyperelliptic_curves: Use sage.rings.abc.pAdicField`
`e1412c7`	`src/sage/schemes/projective/projective_morphism.py: Use sage.rings.abc.pAdicField`
`fc7025a`	`src/sage/rings/padics/generic_nodes.py: Update doctests with deprecation warning output`
`070d05b`	`src/sage/schemes/projective/projective_morphism.py: Avoid merge conflict`
`59271be`	`32750: added missing imports`
`0a1b9ac`	`src/sage/rings/padics/generic_nodes.py: Remove unused imports`
`c46eb46`	`Merge #32665`
`03b24bd`	`src/sage/schemes/berkovich/berkovich_space.py: Whitespace fix`
`c219c17`	`Merge #32750`

Answer 19 · 2021-11-07T17:41:34.000Z

comment:17

trivial merge

Answer 20 · 2021-11-12T23:18:38.000Z

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

`8b888e0`	`Merge tag '9.5.beta6' into t/32777/allow_some_imports_of_rlf_to_fail`

Answer 21 · 2021-11-12T23:18:38.000Z

Changed commit from c219c17 to 8b888e0

Answer 22 · 2021-11-12T23:18:57.000Z

comment:19

Trivial merge with 9.5.beta6

Answer 23 · 2021-11-14T17:08:35.000Z

comment:20

It was already merged, but then the branch changed and now its a merge conflict

Answer 24 · 2021-11-14T18:00:23.000Z

Changed commit from 8b888e0 to c219c17

Answer 25 · 2021-11-14T18:00:23.000Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

Answer 26 · 2021-11-14T18:00:42.000Z

comment:23

Sorry. Back to the previous commit.

Answer 27 · 2021-11-15T23:22:38.000Z

comment:25

still merge conflict

Answer 28 · 2021-11-15T23:28:21.000Z

Changed commit from c219c17 to b49bbdf

Answer 29 · 2021-11-15T23:28:21.000Z

Branch pushed to git repo; I updated commit sha1. New commits:

`5fe8aa6`	`src/sage/geometry/polyhedron/combinatorial_polyhedron/base.pyx: Avoid imports from .all`
`6d5ec0a`	`git grep -l 'all import cached' src/sage \| xargs sed -E -i.bak $'s/^( )from sage.all import (cached_[a-z]) $/\1from sage.misc.cachefunc import \2/'`
`299bd0c`	`git grep -l 'all import .Integer' src/sage \| xargs sed -E -i.bak $'s/^( )from sage.all import Integer $/\1from sage.rings.integer import Integer/'`
`54fa2ee`	`git grep -l 'all import .GF' src/sage \| xargs sed -E -i.bak $'s/^( )from sage.all import GF $/\1from sage.rings.finite_rings.finite_field_constructor import GF/'`
`f9182b4`	`Merge tag '9.5.beta5' into t/32733/remove_more__all_imports`
`2ce2751`	`src/sage/interacts/library.py: Remove unused imports`
`23d8441`	`src/sage/interacts/library.py: suppress pyflakes warning`
`48360b7`	`src/sage/libs/eclib/interface.py: Remove unused import`
`e2d1765`	`Merge tag '9.5.beta6' into t/32733/remove_more__all_imports`
`b49bbdf`	`Merge #32733`

Answer 30 · 2021-11-15T23:28:39.000Z

Changed dependencies from #32742, #32750 to #32742, #32750, #32733

Answer 31 · 2021-12-05T11:15:32.000Z

Changed branch from u/mkoeppe/allow_some_imports_of_rlf_to_fail to b49bbdf