sebas77/Svelto.ECS

Svelto.Common submodule is outdated

Closed this issue · 2 comments

Svelto.ECS can't be used by itself because it uses the updated DBC1 2 3 namespace while the included Svelto.Common submodule is still using the old DesignByContract namespace. From my testing updating Svelto.Common from its current state to the latest commit clears this particular bug.

Note:
For me it's a bit of a problem using submodules because I can't find a way to prevent submodule recursion in GitKraken. I don't know what the solution to this would be - apart from switching git clients - but for now I will stick to only learning Svelto.ECS and leave Svelto.Tasks for later.

I'll fix it today thanks for reporting! I am thinking to remove svelto common from ECS and tasks but the I am not sure if people will have a harder time to understand what to do

Thanks for that. I was trying to use this ECS in a game jam but it was a bit too hard to learn in such a short time.

I think that removing Svelto.Common should be fine as long as it's clearly documented. Some people would probably miss it, so it would also be great if the ECS threw some sort of descriptive error at compile time if Common was missing. Just something that said "X is missing; have you downloaded the Svelto.Common module? link to download". I don't know how easy that is to do though.