[Accepted with Revisions] SDL 0242 Revisions - Subtle Alert Style
theresalech opened this issue · 4 comments
Hello SDL community,
The review of "Revise SDL-0242 Subtle Alert Style - Add SubtleAlert Response" begins now and runs through August 4, 2020.
This will be a review of proposed revisions to a previously accepted but not yet implemented proposal, SDL 0242.
The pull request outlining the revisions under review is available here:
Reviews are an important part of the SDL evolution process. All reviews should be sent to the associated Github issue at:
What goes into a review?
The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of SDL. When writing your review, here are some questions you might want to answer in your review:
- Is the problem being addressed significant enough to warrant a change to SDL?
- Does this proposal fit well with the feel and direction of SDL?
- If you have used competitors with a similar feature, how do you feel that this proposal compares to those?
- How much effort did you put into your review? A glance, a quick reading, or an in-depth study?
Please state explicitly whether you believe that the proposal should be accepted into SDL.
More information about the SDL evolution process is available at
https://github.com/smartdevicelink/sdl_evolution/blob/master/process.md
Thank you,
Theresa Lech
Program Manager - Livio
theresa@livio.io
I think the tryAgainTime parameter in the SubtleAlert response should be in milliseconds to match the SubtleAlert response in the HMI_API https://github.com/smartdevicelink/sdl_evolution/blob/master/proposals/0242-alert-style-subtle.md#hmi_api-changes.
<function name="UI.SubtleAlert" messagetype="response">
<param name="tryAgainTime" type="Integer" mandatory="false" minvalue="0" maxvalue="2000000000">
<description>Amount of time (in milliseconds) that SDL must wait before resending an alert. Must be provided if another system event or overlay currently has a higher priority than this alert.</description>
</param>
</function>I've left a comment on the revision PR.
The Steering Committee voted to accept this proposal with the following revision: change the tryAgainTime parameter in the SubtleAlert response to be in milliseconds instead of seconds.
@joeljfischer please advise when your PR has been updated to reflect the agreed upon revisions. I'll then merge the PR so the proposal is up to date, and leave comments on the implementation issues to reference these updates. Thanks!
Author has updated proposal to reflect agreed upon revisions, and comments have been left on implementation issues: