sparkfun/OpenScale

Checklist v03 protos

Closed this issue · 1 comments

lewispg228 commented

  1. Is proper attribution given to the original designer? [NO]
    comment: designed by is missing in sch

  2. Is the version number correct? [NO]
    comment: missing version in sch

  3. Are 0.1 inch headers lined up on 0.1 inch grid? [NO]
    comment: If you wanted to plug this into a prototyping board, the 3 main headers wouldn't align, sorry I didn't catch this before. I'd say it isn't worth changing at this point.

  4. Are opposing 0.01 inch headers spaced to fit into a breadboard? [NO]
    comment: nope

  5. Does it pass SparkFun DRC? [NO]
    comment: overlap error... arrrr!! also the trace next to the error is a little wonky

nseidle commented

Good catches Pete.

  1. Fixed.

  2. Fixed.

  3. Please keep pushing this check but for this product the 95% use case is not proto board (you are supposed to solder on the load cell wires and use the FTDI header to attach FTDI compatible things).

  4. Can I mark this as 'won't fix'?

  5. What the? I... totally messed that up. Nice catch.

Fixes committed.