[Feature] zed_interfaces as a package?

Question

[Feature] zed_interfaces as a package?

flabrosse opened this issue 3 years ago · 14 comments

I'm trying to use services to talk to the ZED from a different computer than where the ZED is connected (and where the zed.launch is started). This implies having zed_interfaces on this computer. As far as I can see, the only way to have that is to install the whole of the ros wrapper.

Could we have a separate package for zed_interfaces?

This is made even more needed since on the latest ubuntu (20.04), the install fails because the package python-geographiclib is now python3-geographiclib.

Cheers,
Fred

Answer 1 · 2021-07-15T10:23:01.000Z

@flabrosse zed_interfaces is already on a separate package, it's in the same Github repository, but the ROS packages are all separated.
You can simply copy the folder zed_interfaces in the src folder of the catkin workspace of the second computer and start to compile to make everything work.

Answer 2 · 2021-07-15T10:37:30.000Z

Hi @Myzhar, thanks again for the quick response. Yes, this is what I ended up doing, but this also means that if I want to do a git pull, the whole thing will be pulled again. Not the end of the world, just annoying.

Thanks

Answer 3 · 2021-07-21T17:22:18.000Z

+1 for this request. Having interfaces and description packages in their own repo would make a distributed application easier. This repo can even include the new repo as a git sub module

Answer 4 · 2021-07-21T17:33:28.000Z

I see what I can do about this request 👍

Answer 5 · 2021-07-26T13:03:18.000Z

The zed_interfaces package has been removed from this repository and moved to its own zed-ros-interfaces repository for allowing better integration of the ZED Wrapper on remote ground stations that do not require the full package to be installed. To update your repository please follow the new update instructions.

Answer 6 · 2021-07-26T13:26:09.000Z

@Myzhar The meshes from https://github.com/stereolabs/zed-ros-wrapper/tree/master/zed_wrapper/urdf/models should also be moved so you can use rviz remotely without getting errors

Answer 7 · 2021-07-26T13:30:38.000Z

Yes, it makes sense because they are loaded by Rviz and not propagated with the "robot description".

Answer 8 · 2021-07-26T13:58:50.000Z

@davesarmoury done. Now the meshes are in the zed_interfaces repository and they can be correctly loaded by Rviz

$ git pull --recurse-submodules # update recursively all the submodules and it's for you

Answer 9 · 2021-07-26T14:36:34.000Z

Wonderful! Small improvement that will make life much easier :)

Answer 10 · 2021-07-26T14:37:30.000Z

Thank you for your feedback

Answer 11 · 2021-08-02T09:10:20.000Z

Thank you indeed!

Answer 12 · 2021-08-04T13:52:32.000Z

Any particular reason why the package is called zed-ros-interfaces rather than zed_ros_interfaces? The latter is the ROS convention (I myself are in the process of renaming things...)

Answer 13 · 2021-08-04T13:56:33.000Z

Because that's not the name of the package, but the name of the Github repository.
The names of the ROS packages included in this repository follow the ROS naming standard:
zed_ros -> the meta-package
zed_wrapper -> the package that contains the ZED Wrapper
zed_ros_interfaces -> the sub-module including the definitions of the custom topics and services
zed_nodelet -> the package that contains the ZED Nodelets

Answer 14 · 2021-08-04T14:07:39.000Z

Fair enough. I always find it confusing that the top directory is not called the same as the package, but I have seen this before when there is more than one package.