Refactor coneDir to cardir
Closed this issue · 11 comments
coneDir needs to be refactored. @cdondrup found the following which refers to it as "cardinal directions"
Andrew, U. F. "Qualitative spatial reasoning about cardinal directions." Proc. of the 7th Austrian Conf. on Artificial Intelligence. Baltimore: Morgan Kaufmann. 1991.
Maybe cardir?
I'm not sure if it really "needs" to be refactored but I think we should at least list all the QSRs together with the papers where they are described (if any) maybe in the readme or a wiki page. Of course refactoring would make the connection clearer...
I leave it with you. Have a look on the paper I have given above also as it is mentioned there also (also mentioned as cone directions) but there must be some minimal difference between the two.
I'll have a look on Sunday 😄
I looked at both of the above papers, the second paper(2013) referenced the first(1991), so I think this should be used. It is also an older paper.
From section 4 of Qualitative spatial reasoning about cardinal directions (PDF) says:
The most often used, prototypical concept of cardinal directions is related to the angular direction between the observer's position and a destination point. This direction is rounded to the next established cardinal direction. The compass is usually divided into 4 major cardinal directions, often with subdivisions for a total of 8 or more directions. This results in cone shaped areas for which a symbolic direction is applicable. We limit the investigation here to the case of 4 and 8 directions. This model of cardinal direction has the property that 'the area of acceptance for any given direction increases with distance1 (Peuquet and Zhan 1987, p. 66) (with additional references) and is sometimes called 'triangular'.
This suggests that the names are reasonably interchangeable, but cardinal directions refers more to the [N E S W] and [N NE E SE S SW W NS] which we have implimented. Cone direction would refer to different number of divided sections. My personal opinion is that cone direction should be a base class which allows the user to specify the size of the division and rotation from centre North. Cardinal direction can then inherit from that, but with specific configurations (i.e. 4 and 8)
+1 for renaming to carDir, or maybe better cardDir; blah both sound weird.
@pet1330 could you do it?
Yeah, if everyone is ok with this, I'll sort it out 😄
:-p
Don't you mean?
Equally true ;)