set_from_config_file: does it even work still? should be deprecated?
Closed this issue · 8 comments
Only argd currently uses it and whether it still works in 0.2.0 remains to be tested. Should this remain where it is as it complicates things (unncecessariy IMO), or should be provided as a utilities function to a user, or deprecated completely?
I think it should be an option, it shouldn't complicate it too much, even if it just checks the file when starting and passes it as dynamic args automatically thereafter?
Yes, that's where I am leaning towards to; being a functionality offered to the client and the yaml format of the config file should be such that it is read straight as dynamic_args.
Just leave it to the client, yes. Then you can just use the ros internal functions like roslaunch to read the yaml file and get it from the parameter server. Don't burden the lib with that.
OK, since there are no objections it will move to client side. Won't do any changes though before Sunday's LAMOR to keep the lib in its current version.
👍
👍
And @yianni don't forget to remove the corresponding field from the request message.