gpsd_client: Please set frame_id
Closed this issue · 3 comments
nxdefiant commented
The frame_id is currently not set but is required for use with e.g. robot_localization. So please allow to set the frame_id by parameter or just default to "gps".
kriskozak commented
I needed a brief distraction, so I addressed this issue on 7-set-frame-id (https://github.com/swri-robotics/gps_umd/tree/7-set-frame-id). @pjreed, please have a look.
nxdefiant commented
Awesome, btw I forgot that I already created this issue in ros-drivers#6 a few month ago.
pjreed commented
Looks good to me. Want to make a PR for it?