wahn/rs_pbrt

Implement CylindricalMapping2D

wahn opened this issue · 1 comments

wahn commented

On the C++ side we have four classes being derived from TextureMapping2D:

> rg -tcpp "public TextureMapping2D"
core/texture.h
59:class UVMapping2D : public TextureMapping2D {
70:class SphericalMapping2D : public TextureMapping2D {
83:class CylindricalMapping2D : public TextureMapping2D {
100:class PlanarMapping2D : public TextureMapping2D {

So far we have only implemented two on the Rust side:

> rg -trust "impl TextureMapping2D"
src/core/texture.rs
66:impl TextureMapping2D for UVMapping2D {
96:impl TextureMapping2D for PlanarMapping2D {

One of the missing implementors (of the TextureMapping2D trait) is CylindricalMapping2D.

wahn commented

Implemented in the master and the traits branch (cherry picking). See commits f103416 and 1a2fddc ...