Deprecation points to non-existent docs
jguhlin opened this issue · 4 comments
jguhlin commented
DeprecationWarning: FastaReader is being deprecated, please use a table function via the session.
See https://www.wheretrue.dev/docs/exon/exondb/api-reference/table-functions for more info.
That link leads to a "Page Not Found" error
Generated from this code:
bb.FastaReader(seqfile).to_arrow()
(So not using exon)
tshauck commented
Sorry about that... will update to https://www.wheretrue.dev/docs/exon/sql-reference#table-functions.
For FastaReader it'd be:
session = bb.connect()
seqfile = 'test.fasta'
arrow = session.sql(f"""
SELECT *
FROM fasta_scan('{seqfile}')
""").to_arrow()
FWIW I'm not totally sold on deprecating, so please let me know what you think.
jguhlin commented
Cheers. It does seem like a lot of extra complexity to just to get a basic
iterator, but that is just my opinion.
…On Wed, 24 Jan 2024, 11:30 am Trent Hauck, ***@***.***> wrote:
Sorry about that... will update to
https://www.wheretrue.dev/docs/exon/sql-reference#table-functions.
For FastaReader it'd be:
session = bb.connect()seqfile = 'test.fasta'
arrow = session.sql(f"""SELECT *FROM fasta_scan('{seqfile}')""").to_arrow()
FWIW I'm not totally sold on deprecating, so please let me know what you
think.
—
Reply to this email directly, view it on GitHub
<#84 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOA2CBXIONF73ODLGPL7W3YQA2XDAVCNFSM6AAAAABCHX6VIGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBXGAZDQOJXHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
tshauck commented
Cool, yeah, I got a bit of a wild hair, but agree and'll probably leave them in.
jguhlin commented
Very relatable
…On Wed, 24 Jan 2024, 11:53 am Trent Hauck, ***@***.***> wrote:
Cool, yeah, I got a bit of a wild hair, but agree and'll probably leave
them in.
—
Reply to this email directly, view it on GitHub
<#84 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOA2CEQMMAXFMZBIJSZMSTYQA5N7AVCNFSM6AAAAABCHX6VIGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBXGA2TENZTG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>