wsnewman/learning_ros

Issue w/ RViz Config

Opened this issue · 2 comments

mwswartwout commented

The publish_selected_points plugin was updated on 3/6/15 and the name was changed to to selected_points_publisher. The RViz config files in this repo are thus now broken, because they reference (line 233 in mobot_w_lidar_and_kinect.rviz)
Class: rviz_plugin_selected_points_topic/PublishSelectedPoints which should now be
Class: rviz_plugin_selected_points_publisher/SelectedPointsPublisher

This won't result in an error for anyone currently using the learning_ros_external_pkgs repo but does cause a runtime error for anyone with the newest version of the plugin. This doesn't cause a crash and can be solved simply by removing the plugin from the RViz toolbar and re-adding it, but it would probably be better to just update everything to the most recent version.

wsnewman commented

Matt,
Have you noticed if this fixed anything? There were two problems with
the publisher.

  1. the frame_id associated with the data was wrong. The points always seem
    to be in the camera's frame, in spite of the fact that the message being
    published claims the frame_id is the current "fixed frame" of rviz.

  2. the points being published seemed to be only XYZ, not XYZRGB. It would
    be useful to have the color info published with the selected points.

Did you notice if either of these got fixed? Are there new features you
like? (otherwise, any reason to migrate to the new selected-points
publisher?)

On Sun, Mar 27, 2016 at 10:24 PM, Matthew Swartwout <
notifications@github.com> wrote:

The publish_selected_points plugin was updated on 3/6/15 and the name was
changed to to selected_points_publisher. The RViz config files in this repo
are thus now broken, because they reference (line 233 in
mobot_w_lidar_and_kinect.rviz) Class:
rviz_plugin_selected_points_topic/PublishSelectedPoints which should now
be Class: rviz_plugin_selected_points_publisher/SelectedPointsPublisher

This won't result in an error for anyone currently using the
learning_ros_external_pkgs repo but does cause a runtime error for anyone
with the newest version of the plugin. This doesn't cause a crash and can
be solved simply by removing the plugin from the RViz toolbar and re-adding
it, but it would probably be better to just update everything to the most
recent version.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#5

Wyatt Newman, Ph.D., P.E.
Professor, EECS Dept
Case Western Reserve University
Cleveland, OH 44106
216-368-6432
wyatt.newman@case.edu

mwswartwout commented

Haven't tested any of that, but according to the commit history the output
cloud was supposedly made XYZRGB with a commit in February 2015. When is
your copy from?

Matt Swartwout

On Thu, Mar 31, 2016 at 2:04 PM, wsnewman notifications@github.com wrote:

Matt,
Have you noticed if this fixed anything? There were two problems with
the publisher.

  1. the frame_id associated with the data was wrong. The points always seem
    to be in the camera's frame, in spite of the fact that the message being
    published claims the frame_id is the current "fixed frame" of rviz.

  2. the points being published seemed to be only XYZ, not XYZRGB. It would
    be useful to have the color info published with the selected points.

Did you notice if either of these got fixed? Are there new features you
like? (otherwise, any reason to migrate to the new selected-points
publisher?)

On Sun, Mar 27, 2016 at 10:24 PM, Matthew Swartwout <
notifications@github.com> wrote:

The publish_selected_points plugin was updated on 3/6/15 and the name was
changed to to selected_points_publisher. The RViz config files in this
repo
are thus now broken, because they reference (line 233 in
mobot_w_lidar_and_kinect.rviz) Class:
rviz_plugin_selected_points_topic/PublishSelectedPoints which should now
be Class: rviz_plugin_selected_points_publisher/SelectedPointsPublisher

This won't result in an error for anyone currently using the
learning_ros_external_pkgs repo but does cause a runtime error for anyone
with the newest version of the plugin. This doesn't cause a crash and can
be solved simply by removing the plugin from the RViz toolbar and
re-adding
it, but it would probably be better to just update everything to the most
recent version.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#5

Wyatt Newman, Ph.D., P.E.
Professor, EECS Dept
Case Western Reserve University
Cleveland, OH 44106
216-368-6432
wyatt.newman@case.edu

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#5 (comment)