AllenInstitute/bmtk

"TwoSubfieldLinearCell" saves the dominant_filter amplitude for nondominant_filter unit

CloudyDory opened this issue · 0 comments

In line 57-60 of bmtk/simulator/filternet/lgnmodel/cellmodel.py, the dominant_unit and nondominant_unit are created as:

self.dominant_unit = LNUnit(self.dominant_filter, ScalarTransferFunction('s'),
                                    amplitude=self.dominant_filter.amplitude)
self.nondominant_unit = LNUnit(self.nondominant_filter, ScalarTransferFunction('s'),
                               amplitude=self.dominant_filter.amplitude)

This looks strange to me, as the nondominant_unit should save the amplitude as self.nondominant_filter.amplitude.