BroncBotz3481/YAGSL-Example

Modifying pidfproperties.json appears to do nothing --- all PID values set to zero (0), but the robot still drives around?

BlueEyedFoxUnderscore opened this issue · 3 comments

I'm trying to tune my PIDs for the example project.

I've gotten the robot to drive around and almost everything seems to work, except... it shouldn't be driving at all.

Because the robot didn't seem to be responding to my PID changes, I set all the PIDs to zero (0) in controllerproperties.json and pidfproperties.json AND Constants.java, just to make sure the PID values were being read, but our robot still moves! I can't seem to find any other places to set a PID. Very little of the example code has been changed. (The file structure was shifted a little, some variable names, that sort of thing.)

I'm fairly sure the JSON is being read because of the line

private final SwerveSubsystem drivebase = new SwerveSubsystem(new File(Filesystem.getDeployDirectory(), "swerve/neo"));

in src\main\java\frc\robot\RobotContainer.java... and I know the .json files are working in general because if I change other values, like reversing an encoder, the robot responds appropriately. Only the PID values seem to be ignored.

Code: https://github.com/BlueEyedFoxUnderscore/SwerveDrivePankake/tree/main/src/main/deploy/swerve/neo

Why are my PID settings being ignored?

Thanks.

I will not be looking at issues until after worlds, I am sorry! I will ask a few students or some other mentors if they could help however. If you are going to worlds I will help you too!

Good luck!

Are you using sim while saying this or the actual robot? In sim I ignore the PID values entire. On the actual robot I use feedforwards for the drive motors so it may be able to drive back and forth but not have the modules turn. This may also be something still on your RIO and you should reformat it just to be sure.

I am closing this as there has been no progress on information requests.