StatemachineExecutionEngine is a Model
franzlst opened this issue · 2 comments
The class StatemachineExecutionEngine derives from Model. This conflicts with the split between core and GUI. Only the GUI should contain MVC components.
If a model of the execution engine is needed, it should be explicitly created in the mvc.models module.
Originally created by @franzlst (Franz.Steinmetz@dlr.de) at 2015-11-27 07:51:19+00:00 (moved from RMC internal repository)
Solving this issue is not as trivial as for issue #42. The MainWindowController has the StatemachineExecutionEngine as second model, which it observes.
It would suggest to use this situation to make the Execution Engine a child of the State Machine Manager (and not the other way around).
As the MainWindowController must observe changes in the Execution Engine, there should be a new class StatemachineExecutionEngineMoldel, just as there is a Model for every other element of the core.
While doing so, one could also rename StatemachineExecutionEngine to ExecutionEngine, as there is not other Execution Engine and the Engine is a submodule of statemachine anyways.
@sebastian-brunner: Would you do this? 😃
Originally created by @franzlst (Franz.Steinmetz@dlr.de) at 2016-02-05 13:02:39+00:00 (moved from RMC internal repository)
Fixed by @sebastian-brunner in 3bdfcea2c1e05
Originally created by @franzlst (Franz.Steinmetz@dlr.de) at 2016-05-02 14:06:47+00:00 (moved from RMC internal repository)