ntrip_client.launch does not pass rtcm_msg_pkg through as an arg

[arpaterson]

I'm not sure if it is best practice to do it this way, but I have been using include tags in my launch file to refer to the default launch files of packages I am using, rather than duplicating them entirely.

<include file="$(find ntrip_client)/launch/ntrip_client.launch"
...
</include>

That way seems right to me, but I'm open to criticism there.

Anyway, I finally got everything working and remapped between kumar robotics ublox_gps and ntrip_client, but ntrip_client is sending mavros_msgs.

I added <arg name="rtcm_msg_pkg" value = "rtcm_msgs" /> to the above include tag to override the default,
but on inspection, it is not setup as an arg in ntrip_client.launch.

Do you think it should be?

[arpaterson]

I have completely not done my homework.

The feature, including the launch file changes is in this commit for ros1.

I had 1.2.0 checked out, which is too early.

However, the above arg is wrong.

Heres the correct one.

<arg name="rtcm_message_package"   value = "<mavros_msgs or rtcm_msgs>" />

Closing because it works!