dynamics reports crashing with bokeh 3.4.0
handwerkerd opened this issue · 2 comments
Summary
A user just sent me a crashed run and I think the issue is that they are using bokeh=3.4.0, which was released in March 2024.
Additional Detail
The log contains
INFO. tedana:tedana_workflow:903 Generating dynamic report
BokehDeprecationWarning: 'circle() method with size value' was deprecated in Bokeh 3.4.0 and will be removed, use 'scatter(size=...) instead' instead.
The trackback crashes here:
tedana/tedana/reporting/dynamic_figures.py
Line 350 in a21d65e
The bokeh 3.4.0 version release includes Deprecated figure.circle(size=10) in favour of figure.scatter(size=10) API (pull request 13283)
Next Steps
- Confirm this really is causing a full crash with the newest version of Bokeh
- Figure out, if we switch from
circletoscatterif that affects our visualizations or if we'll need to update the minimum acceptable version of bokeh
Summary
A user just sent me a crashed run and I think the issue is that they are using bokeh=3.4.0, which was released in March 2024.
Additional Detail
The log contains
INFO. tedana:tedana_workflow:903 Generating dynamic report BokehDeprecationWarning: 'circle() method with size value' was deprecated in Bokeh 3.4.0 and will be removed, use 'scatter(size=...) instead' instead.The trackback crashes here:
tedana/tedana/reporting/dynamic_figures.py
Line 350 in a21d65e
The bokeh 3.4.0 version release includes Deprecated
figure.circle(size=10)in favour offigure.scatter(size=10)API (pull request 13283)Next Steps
- Confirm this really is causing a full crash with the newest version of Bokeh
- Figure out, if we switch from
circletoscatterif that affects our visualizations or if we'll need to update the minimum acceptable version of bokeh
A follow-up: Uninstalling Bokeh 3.4.0 and installing Bokeh 3.3.0 fixed this issue.
I would say let's limit the version of Bokeh to a maximum of <3.4.0. We can update this later in the future if necessary.