MIPT-ILab/mipt-mips

Wrong "bfp" and "pack" instruction encoding on branch "ooo_window".

ZVasilii opened this issue · 2 comments

ZVasilii commented

RISK-V opcodes for instructions "bfp" and "pack" have changed in 0.92 bitmanip encoding and in MIPT-ILab/riscv-opcodes/opcodes-rv32b file. The dissassembly unit tests have changed in "master" branch but not in the "ooo_window" branch.
"ooo_window"

mipt-mips/simulator/risc_v/t/unit_test.cpp

Lines 324 to 328 in 85e7c47

TEST_CASE("RISCV RV32 bfp")
{
CHECK( RISCVInstr<uint32>(0x08F77833).get_disasm() == "bfp $a6, $a4, $a5");
RISCVInstr<uint32> instr( "bfp", 0);
instr.set_v_src( 0x5555, 0);

"master"

mipt-mips/simulator/risc_v/t/unit_test.cpp

Line 98 in 9486402

TEST_RV32_DISASM ( 0x48F77833, "bfp $a6, $a4, $a5");

"ooo_window"

mipt-mips/simulator/risc_v/t/unit_test.cpp

Lines 249 to 251 in 85e7c47

TEST_CASE( "RISV RV32 pack")
{
CHECK( RISCVInstr<uint32>(0x44d60533).get_disasm() == "pack $a0, $a2, $a3");

"master"

mipt-mips/simulator/risc_v/t/unit_test.cpp

Line 92 in 9486402

TEST_RV32_DISASM ( 0x08d64533, "pack $a0, $a2, $a3");

2 unit-tests are constantly failing.

pavelkryukov commented

The dissassembly unit tests have changed in "master" branch but not in the "ooo_window" branch.
"ooo_window"

Yes, and it is intended, because ooo_window branch uses 0.91 version of submodule.
Therefore, unit tests must be in sync in this version.

pavelkryukov commented

Could you please clarify what is the issue you face?