add this to scipy?
Closed this issue · 5 comments
Following up on:
Could this library be included with scipy?
It's been a longstanding issue in SciPy that the matrix market readers are very slow. This library would meet scipy's standards for inclusion (C++ 11, header only), so I think this is a great opportunity to give great performance gains to a large audience. The scipy maintainers are, in principle, open to this.
On the side of this library, I think it would give potential users much more faith in the maintenance and continued support of this code. For users, it also means fewer python-level dependencies, and no need to worry about possible discrepancies between the parsers.
What do you think? (@eriknw, I would also be interested in hearing your thoughts here).
cc: @grst
Thank you for the proposal @ivirshup. I am linking the existing discussion on SciPy's mailing list.
It looks like we "just" need the work to be done 😃
Great!
This sounds great to me! fast_matrix_market works great for us in python-graphblas, and the few very minor differences compared to scipy.io.mm{read,write} that we found have been addressed.
I just submitted a PR to scipy: scipy/scipy#18631
I just submitted a PR to scipy: scipy/scipy#18631
Merged, so it appears FMM will be part of SciPy 1.12.