copasi_model_obj_common_name needs to be a string

Question

copasi_model_obj_common_name needs to be a string

eagmon opened this issue 3 years ago · 4 comments

this line in core.py can return an invalid model name and leads to an error:
TypeError: Wrong number or type of arguments for overloaded function 'new_CRegisteredCommonName'.
I found this can be fixed by simply converting it to a string. Would be happy to open a PR if I'm given access.

Answer 1 · 2022-03-17T22:08:21.000Z

I'm not sure how this could fail. It sounds like the importing of the model (L327) might have failed and the error wasn't caught. What happens if you import the model that you're trying into the COPASI UI?

Answer 2 · 2022-03-18T09:02:28.000Z

The correct fix would be to call copasi_model.getValueReference().getCN().getString() sorry for the inconvenience.

Answer 3 · 2022-03-18T21:47:44.000Z

Thank you @fbergmann @jonrkarr!

Answer 4 · 2022-03-26T19:22:26.000Z

This will be released as 0.1.35 in a few minutes.