borglab/gtsam

typo in PreintegrationBase.cpp?

Closed this issue · 1 comments

Hello

I am not sure I understand what the whole function is doing, but that H2 || H2 looks like a typo to me (H1 and H2 are OptionalJacobian):

NavState state_j = state_i.retract(xi,
H1 ? &D_predict_state : nullptr,
H2 || H2 ? &D_predict_delta : nullptr);

Is it supposed to be H1 || H2?

Indeed looks like a typo, do you want to make a PR to fix this?