chipsalliance/riscv-dv

Timeout not really kill the subprocess in simulation

jimmysitu opened this issue · 0 comments

Hi, All
I found an issue about the run_cmd timeout feature not really kill all its subprocess. Code shown as below

https://github.com/google/riscv-dv/blob/3df302e15ab4a4305d8eb40d51ef211a072e7b99/scripts/lib.py#L106-L123

Since L107 shell=True, L123 ps.kill() cannot kill the cmd processor when it is timeout.
This issue has been disscus on stackoverflow, here

Can anyone help fix it here?

Thanks