invalid HTML on the front page
tetron opened this issue · 5 comments
On the front page, using Firefox "view source" it is highlighting invalid HTML:
line 69: there is a dangling </nav> but there is no opening <nav>
the features grid has nested anchors (a <a> inside another <a>)
this seems to be due to using <h3> for the box titles, it is inserting <a href="#open-and-free" class="heading__anchor-symbol">§</a>
it probably shouldn't use <h3>, just a div with the appropriate styling.
@lunacodes View source is still showing the dangling </nav> on line 80 on the live site
@lunacodes View source is still showing the dangling
</nav>on line 80 on the live site
@tetron Hmm, so this is a bit of a false flag. The <nav> and <div> tags are all opened/closed in the correct order. The issue is that Jekyll's rendering doesn't maintain indentation when using an {% include %}. So the code's perfectly valid (HTML isn't whitespace-sensitive), it's just rendered sloppily b/c Jekyll is pushing it back to the beginning.
Is there any particular reason to look into it, outside of the validator flagging it? If not, I don't think it's worth looking into. (I already tried a bit yesterday, but Jekyll is stubborn about this behavior).
@mr-c thanks for the list. I'll have a fix for the errors up tonight, except for:
- Error: Bad value https://matrix.to/#/#common-workflow-language_common-workflow-language:gitter.im for attribute href on element a: Illegal character in fragment: # is not allowed.
It's the correct link - so nothing can be done there.
Nos. 9-11: These are all the same error that @tetron and I were discussing above.
@lunacodes thanks! Yeah, the w3c validator is quite picky. I wouldn't treat every error it throws as a huge problem, especially if things work. Glad it seems not too difficult to fix the parts it did complain about.