Global code review

Question

Global code review

antoinealb opened this issue 10 years ago · 7 comments

@Stapelzeiger said we should do a code review of the bootloader. Should we do it before it is finished ?

Answer 1 · 2014-12-16T15:59:24.000Z

I'm for doing it before. It's more efficient.

On Dec 16, 2014, at 4:56 PM, Antoine Albertelli notifications@github.com wrote:

@Stapelzeiger https://github.com/Stapelzeiger said we should do a code review of the bootloader. Should we do it before it is finished ?

—
Reply to this email directly or view it on GitHub #21.

Answer 2 · 2014-12-16T16:00:45.000Z

Something formal ? Like printing the whole code and highlighting the "wrong" parts ? If we do something less formal we will need a volunteer !

Answer 3 · 2014-12-16T16:08:40.000Z

if you want i can help you with the code review (= (for example tomorrow)

Answer 4 · 2014-12-16T17:59:58.000Z

I'll review the code. I'll probably have time between Christmas and New-Year.
I was thinking about commenting the code and give you the diff. (I need ctags/search function since I'm not familiar with the codebase.)

Answer 5 · 2014-12-16T21:37:49.000Z

I am ok with whatever method for code review. Maybe fork it and open a PR with your comment and fixes ?

Answer 6 · 2015-01-03T21:28:44.000Z

any updates on this ?

Answer 7 · 2015-01-04T16:56:29.000Z

I couldn't find the time to do a full review. I only took a quick look at the code. On first impression it looks OK, but there are some checks missing.
I guess as soon as it works we should move to the next thing since we still have quite a lot to do. For a later version (next year) we should probably improve a few things and I'd still like to do a full review sometime, but it's currently not on my priority list.