cytomining/cytominer

Unused argument in correlation_threshold

cells2numbers opened this issue · 2 comments

The function

correlation_threshold <- function(population, variables, sample, cutoff = 0.90,
                                  method = "pearson") 

defines the argument population. In the following code, population is not used.

Question: is the population argument used to have a more unique signature for all cytominer functions or can it be removed?

You are right - it should be removed. Also true for variance_threshold

Fixed with #58