endless-sky/endless-sky

Idea: Standardise the leave/done/depart text and hotkeys

Opened this issue · 10 comments

brendanjones commented

Problem Description

As a seasoned player you'd think I'd be very used to these by now, but I still find myself hitting the wrong button to leave some places.

The various buttons we have to navigate away from places:

Done: Player Info, Map, Jobs (which is Map)
Leave: Shipyard, Outfitter
Depart: Leave planet
None: Messages (have to re-press the Messages hotkey, press escape, or click off the Messages panel), Spaceport (kinda related #3389), Bank, Trading, Hire Crew.

Pressing D will let you leave the Shipyard and Outfitter, but pressing L will not let you leave Player Info (it'll instead open the Logbook) or Map.

Related Issue Links

Can't find any.

Desired Solution

Is the idea that you don't accidentally leave the planet? Because then I'd say:

  1. change Leave to Done in the Shipyard and Outfitter, and
  2. change Depart to Leave Launch.
  3. Stop L hotkey leaving Outfitters and Shipyard.
  4. Messages should have a Done button added. (could do at same time as #9999 )

That standardises all dismissal actions to Done (with hotkey D) except for leaving the planet.

Alternative Approaches

Open to discussion.

Additional Context

No response

brendanjones commented

Hey Issue #10000 whaddupppppp that's a cool milestone.

  • 🎉6
xX-Dillinger-Xx commented

If I follow your idea correctly, D would exit everywhere except the planet and L would leave\launch. Is that correct?
If it is, that all makes sense to me, but I would like to suggest one small edit.

and change Depart to Leave.

Change Depart to Launch

brendanjones commented

If I follow your idea correctly, D would exit everywhere except the planet and L would leave\launch. Is that correct?

Correct.

Change Depart to Launch

That is an excellent suggestion, will change the issue description.

  • 👍3
xX-Dillinger-Xx commented

I really like this idea.

Ferociousfeind commented

Makes sense to me, especially if L is also Land, so L toggles whether or not you're on a planet

Also happy 10k, we got there before the SCP wiki did

  • 👍1
brendanjones commented

especially if L is also Land, so L toggles whether or not you're on a planet

Yup, exactly. That was why I suggested Leave/Launch with an L, while the others get changed to D.

ziproot commented

I think endless sky follows IBM CUA, so pressing esc lets you escape shipyard, outfitter, player info panel, message log, etc. The only time this won’t work is for departing a planet, which is the d key, as pressing esc takes you back to the main menu.

TomGoodIdea commented

Worth noting that L is currently used on the planet interface to return to the planet's description (same effect as clicking the landscape image).

  • 👀1
Ferociousfeind commented

We should change it from "L" for Landscape to "D" for Describe :)

brendanjones commented

(same effect as clicking the landscape image).

Had no idea that was a thing! Still not matter how long I play there are still things to learn :)

And yeah, if all the other non Launch hotkeys are D then it seems logical to me to also switch that one to D.

  • 👍2