endless-sky/endless-sky

When auto-selecting which ship to board, the order of these ships should be (Marauder) Quicksilver > Bounder > Arrow

Closed this issue · 3 comments

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

I'm not sure the exact mechanic that decides which ship should be boarded first, but it seems to be generally correct.

However it's wrong for the Marauder Quicksilver, Marauder Bounder and Marauder Arrow. The order now is Arrow > Bounder > Quicksilver when it should be the opposite, given the Quicksilver is the most valuable ship, then the Bounder, then the Arrow.

Steps to Reproduce

  1. Have a 'small marauders' mission
  2. disable the ships
  3. select 'b' to auto-select a ship to board
  4. The Arrow will be selected first then the Bounder, then the Quicksilver

Expected Behavior

Quicksilver > Bounder > Arrow

Screenshots

No response

Link to save file

Any

Operating System

MacOS

Game Source

Steam

Game Version

0.10.6

Additional Information

I have not checked if this bug applies to any other ships, or the non-Marauder variants of these ships. I simply noticed it for these specific ships.

Looking into this further, I'm guessing the order is like this because it's the correct order for the non-Marauder variants, based on ship value?

This is intended behaviour. If you haven't made any ship scans, the boarding target algorithm uses the empty hull cost of a ship to determine its value. The M. Arrow has a hull price of 1.32M, while the M. Bounder and M. Quicksilver cost 1.25M and 1.2M respectively. Outfit price is only included into the calculation if you scan the ship.

Hmmm. I understand it, but I don't like it.

In any case, an Arrow is far weaker than a Quicksilver, and that should be reflected in the price: #9994