ethz-asl/curves

Incomplete behaviour of HermiteCoefficientManager::getCoefficientsAt

rdube opened this issue · 2 comments

rdube commented

In the case where the time falls exactly on a coefficient, only one coefficient should be returned, not a pair of coefficients. To our understanding, two coefficients should only be returned when the time falls between two coefficients.

We see three possible cases :
1 - Time out of bounds => error
2 - Time between two coefficients => two coefficients should be passed
3 - Time on a coefficient => what should the behaviour of this function be?

Would the user have to call a getCoefficientAt() (singular) or hasCoefficientAtTime() function to check if the time falls on a coefficient, before calling the getCoefficientsAt() ?

Please advice.

furgalep commented

Resolved?

rdube commented

Still needs to be tested.

On Sat, Aug 23, 2014 at 7:37 AM, Paul Furgale notifications@github.com
wrote:

Resolved?

—
Reply to this email directly or view it on GitHub<
https://github.com/ethz-asl/curves/issues/20#issuecomment-53143520>.

Renaud Dubé
Autonomous Systems Lab.
ETH-Zürich
http://www.asl.ethz.ch/