`if (${CATKIN_ENABLE_TESTING})` not supported

Question

`if (${CATKIN_ENABLE_TESTING})` not supported

Closed this issue 4 years ago · 4 comments

peci1 commented 4 years ago

I decided to use the more bulletproof if (${CATKIN_ENABLE_TESTING}), but I keep getting UNGUARDED_TEST_CMD error.

peci1 commented 4 years ago

Thanks!

Answer 1 · 2020-06-09T17:24:38.000Z

Why exactly do you think this is more bulletproof? It is vulnerable to spurious variable expansions.

Answer 2 · 2020-06-09T20:37:05.000Z

Hmm, I got the impression that the ${} approach is the preferred one and the other one is going to be abandoned one time... But apparently, I was wrong.

It just seems like a big inconsistency to me... And there is https://cmake.org/cmake/help/latest/policy/CMP0054.html which aims towards the ${} version without spurious expansions.

Answer 3 · 2020-06-10T08:48:07.000Z

And there is https://cmake.org/cmake/help/latest/policy/CMP0054.html which aims towards the ${} version without spurious expansions.

That is true, but you'd have to use if("${CATKIN_ENABLE_TESTING}") then (note the extra quotes). I still find if(CATKIN_ENABLE_TESTING) the simplest and most aesthetically pleasing, but I made catkin_lint work with both versions.