Relax Pydantic V1 constraint from `==1.10.16` to `>=1.10.16`

Question

Relax Pydantic V1 constraint from `==1.10.16` to `>=1.10.16`

tcompa opened this issue 6 months ago · 3 comments

tcompa commented 6 months ago

cc @lorenzocerrone

Answer 1 · 2024-06-21T10:01:57.000Z

I will quickly open a pr for this in the afternoon

Answer 2 · 2024-06-26T11:55:10.000Z

As you mentioned @tcompa during the last pydantic PR review, there is no strong reason to pic pydantic>=2.6.3.

Since I needed to rework the version check anyway, I want to test if the manifest creation is compatible with all pydantic 2* versions. The answer is yes; from version 2.0.0 the manifest building works and has no diffs from the current version in main.

After my tests I don't see any reasons to keep the runtime check.
Should I remove it? And just leave the simple version constraint pydantic >=1.10.16?

Answer 3 · 2024-06-26T12:10:14.000Z

After my tests I don't see any reasons to keep the runtime check.
Should I remove it? And just leave the simple version constraint pydantic >=1.10.16?

I agree.
If we ever hit an issue with some manifest building coming from e.g. pydantic 2.3, we can quickly re-introduce the runtime version constraint. But note that this would only happen if someone is pinning pydantic=2.3 in their own package.