intel/systemc-compiler

build.sh removal intentional ?

dlmiles opened this issue · 5 comments

A build.sh was added recently and announced in commit log.
Then a few weeks later is was removed, unannounced.
Was the removal intentional ?

Removal commit:
c4dfc80

The script returned with install_icsc.sh name.

Thank you for your commit and push of 1 hour ago, good to see it return.

Should the HASH BANG be the first line in the file ?

#!/bin/bash -e

It appears to work, but I don't think the 'set -e' fail fast on first error is working as-is.

This one is our standard bash script first line. What is the problem? How you suggest to update it?

Move line 8 containing #!/bin/bash -e as line 1
Put copyright credits below line 1.
Looks like they were inserted above HASH BANG and may not have been present at all in the previous build.sh file this issue#49 refers to.

#! only works as line 1. I think you know this from your comment.
Right now line 8 is ignored as a comment, the -e which causes set -e option does not take effect. The -e option is a good thing for a build script to fail fast.

This issue can be closed, I have successfully built SystemC over the past 24h.

Many Thanks for the prompt replies.

Oh, yes. Thank you. Will fix it next commit.