j-andrews7/STRprofiler

CLASTR results with multiple entries for a given line do not display

j-andrews7 opened this issue · 4 comments

j-andrews7 commented

Guessing you're aware already, but I've noticed that results from lines with multiple entries do not show up in the single query - JMAR is kind of my test "contaminated" sample that would make a good example for the paper.

image

As opposed to the CLASTR site:

image

MikeWLloyd commented

In parsing the results, I used 'best' when multiple results were returned.

https://github.com/j-andrews7/strprofiler/blob/1bd91a99be750effb4dc609d3bd1d5df26ddeac6/strprofiler/shiny_app/clastr_api.py#L49-L54

We can revisit that choice, but it would need to have the hard coded regex adjusted.

j-andrews7 commented

Currently, I don't think it returns best or worst, so probably some tinkering needed regardless.

MikeWLloyd commented

I left it to report only profiles_0 in the results object for each returned result. I was thinking that is the top hit. I synonymized that with best in my mind, but I see now that is not correct. I will see about parsing all profiles in each result dict/array combo.

  • 👍1
MikeWLloyd commented

fix parses both profile 0 and 1, and annotates the result in the table with 'Best' and 'Worst'

  • 🎉1