jeremyong/klein

Bug in `motor::operator=(translator t)`

Closed this issue · 2 comments

Danvil commented

I believe there is a bug in this code:

    motor& KLN_VEC_CALL operator=(translator t) noexcept
    {
        p1_ = _mm_setzero_ps();
        p2_ = t.p2_;
        return *this;
    }

The rotator p1_ should be set to identity instead of zero.

jeremyong commented

Nice catch! Fixed

Danvil commented

Thank you for confirming and fixing it!