mapping-commons/sssom-py

Fix all the other `^` dependencies to '>='.

matentzn opened this issue · 0 comments

matentzn commented 
          Why not fix all the other `^` dependencies to '>='. As a core library that

is reused in multiple other projects, sssom-py simply has to be less
opinionated about versions.

Do we even need scipy as a core dependency?

I think I am responsible for introducing this:
https://github.com/mapping-commons/sssom-py/blame/master/src/sssom/cli.py#L488C32-L488C32

Back when sssom-py was a bit more experimental. But if people are really
using this non-core function perhaps this could be an extra.

We really need to be making our core python libraries more lightweight.
Note every design decision from 3+ years ago is set in stone. We can start
moving out non-core functionality into separate packages, plugins, or make
the dependency an extra.

On Fri, Jul 14, 2023 at 1:51 PM Harshad @.***> wrote:

I switched sssom-py to using any version of python >= 3.8 but < 4.0.0
(for now). Due to this, poetry complained abut spicy having conflicting
python version compatibility.

Solution poetry add scipy="*": What this does is finds a compatible
version of scipy and installs it. This will fix some headache in the
future.

You can view, comment on, or merge this pull request online at:

#391
Commit Summary

  • 25a0470
    25a0470
    scipy latest version creating incompatibility errors.

File Changes

(2 files https://github.com/mapping-commons/sssom-py/pull/391/files)

Patch Links:

—
Reply to this email directly, view it on GitHub
#391, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAMMOMLPHMXCPF4RBKBRTTXQGWLXANCNFSM6AAAAAA2KZDQS4
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Originally posted by @cmungall in #391 (comment)