ome/bioformats

Switch clauses have same code

Closed this issue · 1 comments

scuniff commented

As wanted??

bioformats/components/formats-gpl/src/loci/formats/in/ZeissCZIReader.java

Lines 2128 to 2143 in 682bc7e

case 'B':
if (extraIndex >= 0) {
extra[extraIndex] = dimension.start;
if (extra[extraIndex] >= extraLengths[extraIndex]) {
extra[extraIndex] = 0;
}
}
break;
case 'M':
if (extraIndex >= 0) {
extra[extraIndex] = dimension.start;
if (extra[extraIndex] >= extraLengths[extraIndex]) {
extra[extraIndex] = 0;
}
}
break;

dgault commented

Thank you for opening the issue @scuniff, in this case the switch clauses are meant to have the same code. These could be combined into a single case statement to reduce the duplication but for readability the current code also works well.