Pruning of react-component fields that no longer work in redesign_v2
cnboonhan opened this issue · 4 comments
I would like to propose the removal of the following components in the dashboard that no longer seem to be propagated correctly in redesign_v2:
Checking / unchecking these checkboxes do not seem to visually change anything
Start Location and Destination are always empty here. Active Task Duration is also not populated:
Location and Destination are undefined here. Task progress is also always at 11%:
How was progress being measured previously? I'm not sure there's any meaningful way to measure progress, tbh. Best case scenario would be to base it off of time estimates, but then we could see progress slide backwards due to delays.
How was progress being measured previously? I'm not sure there's any meaningful way to measure progress, tbh. Best case scenario would be to base it off of time estimates, but then we could see progress slide backwards due to delays.
iirc, it was using a super naive approach of (current_time - start_time) / (est_end_time - start_time). It's quite bad for the ui because progress would continue going up even if a task is stalled for any reason. It should work as long as rmf continuously update est_end_time to reflect the latest prediction.
I think we have enough information now to go back to that definition of progress, at least until we can think of something more meaningful.