Feature request: option to skip installation of DDS packages
Opened this issue · 0 comments
Description
This is a very useful action step for setting up a workflow that compiles packages in a colcon workspace. Since colcon is a tool that can be used in non-ROS contexts, I wanted to see if there is interest in using this action without installing DDS packages.
cc @stonier
Related Issues
N/A
Completion Criteria
Add a parameter for skipping installation of DDS packages.
Implementation Notes / Suggestions
It looks like the logic for installing DDS implementations is intermingled with the logic for installing compilers and development tools in the package_manager/apt.ts file.
DDS-specific lines:
- https://github.com/ros-tooling/setup-ros/blob/39f9fe76c8bf5baaa/src/package_manager/apt.ts#L7
- https://github.com/ros-tooling/setup-ros/blob/39f9fe76c8bf5baaa/src/package_manager/apt.ts#L30-L34
- https://github.com/ros-tooling/setup-ros/blob/39f9fe76c8bf5baaa/src/package_manager/apt.ts#L39-L40
- https://github.com/ros-tooling/setup-ros/blob/39f9fe76c8bf5baaa/src/package_manager/apt.ts#L52-L53
Perhaps the DDS-specific lines could be split into a separate file to more easily enable or disable the DDS packages.
Testing Notes / Suggestions
Test a typical ROS workflow with DDS installed and a workflow without DDS installed and confirm that the setup time is reduced without the extra packages.