sagemath/sage

sage.doctest: Remove handling of sagenb

Closed this issue · 13 comments

mkoeppe commented

Follow up from #28834.

See also #29754 and #29885.

CC: @fchapoton @jhpalmieri @kliem

Component: doctest framework

Author: Matthias Koeppe

Branch/Commit: da41966

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/29940

mkoeppe commented

Commit: ad00b40

mkoeppe commented

Author: Matthias Koeppe

mkoeppe commented

Description changed:

--- 
+++ 
@@ -1 +1,2 @@
+Follow up from #28834.
mkoeppe commented

New commits:

6bec225sage.doctest.forker.DocTestTask._run: Remove special support for sagenb
ad00b40sage.doctest, src/bin/sage-runtests: Remove handling of sagenb
tscrim commented

Reviewer: Travis Scrimshaw

tscrim commented
comment:3

This for loop is now redundant:

        for o in ("all",):
            if o in opt:
                raise ValueError("You cannot run gdb/valgrind on the whole sage%s library"%("" if o == "all" else "nb"))

and the error message is no longer needs the choice.
Other than that LGTM.

tscrim commented

Description changed:

--- 
+++ 
@@ -1,2 +1,3 @@
 Follow up from #28834.
 
+See also #29754 and #29885.
sagetrac-git commented

Changed commit from ad00b40 to da41966

sagetrac-git commented

Branch pushed to git repo; I updated commit sha1. New commits:

da41966src/sage/doctest/control.py: Simplify singleton loop
tscrim commented
comment:5

Thank you. LGTM.

mkoeppe commented
comment:6

Thanks!