Unexpectedly bad results for billiards.py variant

Question

Unexpectedly bad results for billiards.py variant

Opened this issue 4 years ago · 5 comments

In billiards.py, I've done some changes to the starting condition of the cue ball and the target position. These changes are available here.

What I observed was that in almost every iteration, the result got worse than before not better.
i.e. Loss seems to be increasing:

The ending stable state is not that surprising (no gradient) but the initial trend is concerning me.

Answer 1 · 2020-02-10T21:53:24.000Z

The billiards example is not implemented with the time-of-impact fix (see our paper) so I'm not surprised that it's making inverse progress. I'll fix this in a few days.

Answer 2 · 2020-02-10T22:50:28.000Z

Thanks! Looking forward to it.

…

On Tue, 11 Feb 2020 at 08:53, Yuanming Hu ***@***.***> wrote: The billiards example is not implemented with the time-of-impact fix (see our paper) so I'm not surprised that it's making inverse progress. I'll fix this in a few days. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#14>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGY2BATTZ2NLDHYTLTAEMLRCHEFJANCNFSM4KRWZHJA> .

Answer 3 · 2020-02-14T04:13:06.000Z

Hi @DomNomNom ,

I added the TOI fix to billiards.py. Gradient quality is significantly improved. Could you have a try? (PS: please also upgrade taichi to 0.4.6+). Thanks.

Answer 4 · 2020-02-15T23:57:58.000Z

Hi @yuanming-hu

I've updated taichi and merged your changes, however I'm still seeing similar symptoms:

Here's what I'm running: https://github.com/DomNomNom/difftaichi/blob/5326ebfc1c8bd5bfe56b3ba5b68ad891b158aa20/examples/billiards.py
Note: after updating, pip3 list | grep taichi gave me taichi-nightly-cuda-10-1 0.5.0.

Answer 5 · 2020-03-05T12:46:28.000Z

Any thoughts on this?