vincentfung13/MINE

Inplement detail about plane homography warping between src camera and tgt camera.

SunshineWYC opened this issue · 2 comments

In operations/homography_sampler.py file,
1
Line 107-108 calculate plane homography warping matrix between src camera and tgt camera, following the equation:
2
While the K_inv should be K_tgt_inv, not the K_src_inv, K should be K_src. This issue will not happen when K_tgt=K_src, but cause error when intrinsics are not equal.
H_tgt_src = torch.matmul(K_src, torch.matmul(R_tnd, K_tgt_inv))

Here, the author first computes homography matrix (H_tgt_src) that warps pixels in the source view to the target view and then inverse it ( line 113 in operations/homography_sampler.py ). So for this question, the release code is right.

Thanks for apply, the inplement is right. I misunderstood this detail when firstly reading the code.
Sincerely,thanks very much for your work.